Change in ovirt-engine[master]: webadmin, userportal: Improve UiCommon Editor integration
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin,userportal: Improve UiCommon Editor integration
......................................................................
webadmin,userportal: Improve UiCommon Editor integration
This patch makes UiCommonEditorVisitor work with new interface
(UiCommonEditor) instead of using WidgetWithLabelEditor class
directly.
UiCommonEditor interface can now be implemented by any specific
editor class, i.e. we're no longer limited by using only
WidgetWithLabelEditor bound to specific widget type
(AbstractValidatedWidgetWithLabel).
Change-Id: Ifd5a5456966b99e9d2eef8b5a0199f04793b315e
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
A
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/editor/UiCommonEditor.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/editor/UiCommonEditorVisitor.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/WidgetWithLabelEditor.java
3 files changed, 47 insertions(+), 18 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23246
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifd5a5456966b99e9d2eef8b5a0199f04793b315e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server