Change in ovirt-engine[ovirt-engine-3.4]: Maintenance mode shall persist after reboot
Itamar Heim has submitted this change and it was merged.
Change subject: Maintenance mode shall persist after reboot
......................................................................
Maintenance mode shall persist after reboot
Fencing operations can occur as a result of manual operation or
automatically after Host was in non-responsive state and has been
restarted after waiting the grace-time for it to reconnect.
In the case that Host was in Maintenance
1) If it was manually started , it should stay in maintenance
2) If it was manually restarted it should change first to reboot and move back to
Maintenance when the Host is ON again.
In the case that Host is restarted from the non-responsive treatment, it
should go to reboot -> non responding -> up as before
This patch address 1) and 2) above by
1) Setting the parent command in VdsNotRespondingTreatmentComman
parameters so the Restart command can distinguish between manual Restart and
automatic restart
2) Add a flag to FenceVdsActionParameters to mark if Host should be
moved again to Maintenance after it was restarted
3) Use The Host last status to skip changing the status in case of 1)
4) Use the flag described in 2) to set Host again to Maintenance in
case that Host was manually rebooted while in the Maintenance status.
Change-Id: I3dcb06b18c4af13876d1fb3043fb5b6cc5c6a74a
https://bugzilla.redhat.com/show_bug.cgi?id=917039
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestartVdsCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StartVdsCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/FenceVdsActionParameters.java
5 files changed, 24 insertions(+), 3 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Eli Mesika: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23822
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3dcb06b18c4af13876d1fb3043fb5b6cc5c6a74a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>