Change in ovirt-engine[master]: core: Un-mock GetDeviceListVDSCommandTest
Michael Kublin has submitted this change and it was merged.
Change subject: core: Un-mock GetDeviceListVDSCommandTest
......................................................................
core: Un-mock GetDeviceListVDSCommandTest
GetDeviceListVDSCommandTest uses Mockito to mock XmlRpcStruct, which is
quite redundent - it's a simple data-object, with no underlying logic.
This patch removed the mocking and uses XmlRpcStruct directly, which
makes the test easier to read and maintain.
Change-Id: I599fd0050deab4142245af3ccce08d790fbf139c
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetDeviceListVDSCommandTest.java
1 file changed, 10 insertions(+), 15 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5333
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I599fd0050deab4142245af3ccce08d790fbf139c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>