Daniel Erez has submitted this change and it was merged. Change subject: core: SEAT compensate - prevent IndexOutOfBounds ...................................................................... core: SEAT compensate - prevent IndexOutOfBounds CommandBase -> hasTaskHandlers: * compensate: setExecutionReason to ROLLBACK_FLOW for ensuring internalEndWithFailure flow as in revertPreviousHandlers. * internalEndWithFailure: verifying executionIndex >= 0 to prevent index underflow. * revertPreviousHandlers: when executionIndex < 0 set command as succeeded (to ensure tasks clean up). Change-Id: I7af9f3ab3bfce91b114d82145957909ba1ee7819 Bug-Url: https://bugzilla.redhat.com/966153 Bug-Url: https://bugzilla.redhat.com/966618 Bug-Url: https://bugzilla.redhat.com/965676 Bug-Url: https://bugzilla.redhat.com/962497 Signed-off-by: Daniel Erez <derez@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 13 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15133 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7af9f3ab3bfce91b114d82145957909ba1ee7819 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk@redhat.com>