Change in ovirt-engine[master]: core: Cleanup AttachDiskToVmCommand.canDoAction()
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Cleanup AttachDiskToVmCommand.canDoAction()
......................................................................
core: Cleanup AttachDiskToVmCommand.canDoAction()
Made the canDoAction() more readable by removing the lock checks (should
be handled by the CommandBase infra using @LockiIdNameAttribute) and
employing the early-return idiom.
Relates-To: https://bugzilla.redhat.com/854964
Change-Id: I6cb0cc87c82387e8b1dcac0142f3625a4cc232d2
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java
1 file changed, 28 insertions(+), 29 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12894
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6cb0cc87c82387e8b1dcac0142f3625a4cc232d2
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>