Allon Mureinik has submitted this change and it was merged. Change subject: core: AddDiskCommandTest: rm redundant VM mocking ...................................................................... core: AddDiskCommandTest: rm redundant VM mocking AddDisk deals primarily with adding disks (unsurprisingly), although it has a small overlap with VMs as it allows to add and attach a disk in a single action. Most of the test cases, though, do not relate to VMs, and mocking a VM into them just bloats the code and confuses the reader. This patch reduces the VM mocking to where its actually needed in order to make the test more concise and easier to read. Change-Id: I0984bd695054dd5143cfa3bd7458a3fb26a8ac78 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommandTest.java 1 file changed, 7 insertions(+), 18 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64946 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0984bd695054dd5143cfa3bd7458a3fb26a8ac78 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>