Change in ovirt-engine[master]: webadmin: change how warning on imported vm is stored
Arik Hadas has submitted this change and it was merged.
Change subject: webadmin: change how warning on imported vm is stored
......................................................................
webadmin: change how warning on imported vm is stored
Until now, each VM that we wanted to present a warning for in the import
dialog was stored in a list of VMs (called disksToConvert..) and then a
warning was presented for a VM if it was in that list.
This patch changes this approach: instead of having list of VMs, we
store the warning in the VM's import model which makes more sense from
the design point-of-view, especially as we also need to show other
warnings/errors (will be implemented in a different patch)
Change-Id: I3b636821f264b63d6ad0b8c9fd7592cb6e10d41c
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/ImportTemplateModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmData.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExportDomainModel.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmFromExportDomainPopupView.java
D
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/IsProblematicImportVmColumn.java
5 files changed, 25 insertions(+), 48 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/39878
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3b636821f264b63d6ad0b8c9fd7592cb6e10d41c
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server