Change in ovirt-hosted-engine-ha[master]: hosted-engine: hosted-engine client, with storage connection...
Martin Sivák has submitted this change and it was merged.
Change subject: hosted-engine: hosted-engine client, with storage connection timeout
......................................................................
hosted-engine: hosted-engine client, with storage connection timeout
When a hosted-engine client (cli or broker) is requesting status from hosted engine vm and
there is
no connection to storage domain. The client is hanging indefinalty, waiting
for response.
The fix is
1. Added timeout using socket's select, In lib.util.socket_readline
2. Modified lib.brokerlink._communicate() to use timed read requestes.
3. Add OSError exception trap on storage connection. Trapping mounting errors.
Assuring the broker caller recieves applicative errors response.
Change-Id: I3be8d3cff0912c7a88ebb00145a17fa6dd2d892d
Bug-Url: http://bugzilla.redhat.com/1208489
Signed-off-by: Dudi Maroshi <dudi(a)redhat.com>
---
M ovirt_hosted_engine_ha/broker/storage_broker.py
M ovirt_hosted_engine_ha/env/constants.py.in
M ovirt_hosted_engine_ha/lib/brokerlink.py
M ovirt_hosted_engine_ha/lib/brokerlink_test.py
M ovirt_hosted_engine_ha/lib/util.py
5 files changed, 33 insertions(+), 9 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Martin Sivák: Looks good to me, approved
Dudi Maroshi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/40392
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3be8d3cff0912c7a88ebb00145a17fa6dd2d892d
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org