From Tomas Jelinek <tjelinek(a)redhat.com>:
Tomas Jelinek has submitted this change and it was merged.
Change subject: core: fixed tests
......................................................................
core: fixed tests
1) these tests weren't run by maven. Not sure why, since there are
different tests not ending with …Test, and those are run. However
renaming them fixed the issue.
2) while these tests weren't run, some errors accumulated in them.
This was fixed.
3) added toString method to ReportedConfiguration class for easier
debugging.
Change-Id: Ib49810bb6bcb9c80acdd777f72727c20301ef742
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M
backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/BaseNetworkImplementationDetailsUtilsTest.java
R
backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/NetworkImplementationDetailsUtilsUsingBaseNicTest.java
R
backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/NetworkImplementationDetailsUtilsUsingVlanNicTest.java
3 files changed, 23 insertions(+), 13 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Martin Mucha: Verified
Jenkins CI: Passed CI tests
--
To view, visit
https://gerrit.ovirt.org/65430
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib49810bb6bcb9c80acdd777f72727c20301ef742
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>