Change in ovirt-engine[master]: core: Extract common Custom Properties code
Lior Vernia has submitted this change and it was merged.
Change subject: core: Extract common Custom Properties code
......................................................................
core: Extract common Custom Properties code
Moved basic validation from SimpleCustomPropertiesUtil to
CustomPropertiesUtils, as well as some validation from
VmPropertiesUtils that should be common to all custom properties.
Removed a lot of additional logic from VmPropertiesUtils that could be
accomplished using logic already existing in CustomPropertiesUtils (in
some cases after small modifications).
Change-Id: I24efa004b1b7fe4359046bca1e6c87188cececf9
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/customprop/CustomPropertiesUtils.java
M
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/customprop/SimpleCustomPropertiesUtil.java
M
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/customprop/VmPropertiesUtils.java
3 files changed, 89 insertions(+), 207 deletions(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27384
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I24efa004b1b7fe4359046bca1e6c87188cececf9
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server