From Tal Nisan <tnisan@redhat.com>:
Tal Nisan has submitted this change and it was merged. Change subject: core: when moving VM to another cluster, update its macs… ...................................................................... core: when moving VM to another cluster, update its macs… when moving VM to another cluster, and those clusters has set different Mac Pools set, then macs needs to be updated. All macs of such VM needs to be removed from Mac Pool of source Cluster and added to Mac Pool of target cluster. If target Mac Pool disallows duplicates and there's clash, operation will be suspended. Change-Id: Ic57ff7ac249946fa0eafc6034bada1ee86d31b7f Bug-Url: https://bugzilla.redhat.com/1410440 Signed-off-by: Martin Mucha <mmucha@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVMClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVmClusterValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveMacs.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/ReadMacPool.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ChangeVMClusterCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ChangeVmClusterValidatorTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveMacsTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpool/TransactionalMacPoolDecoratorRollbackTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 14 files changed, 615 insertions(+), 28 deletions(-) Approvals: Martin Mucha: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/74029 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic57ff7ac249946fa0eafc6034bada1ee86d31b7f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Martin Mucha <mmucha@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>