Change in ovirt-engine[master]: userportal: removing a user from 1 pool - UP fails
Gilad Chaplik has submitted this change and it was merged.
Change subject: userportal: removing a user from 1 pool - UP fails
......................................................................
userportal: removing a user from 1 pool - UP fails
When a user has rights on a VM which is a part of a pool,
which he does not have rights to, than no pools will be shown
on the UP at all.
The problem was in VmItemBehavior.UpdateProperties() on line 172.
The problem is, that when there is a VM which has a pool, but the
user does not have rights on this pool, the frontend throws an
exception. The pool was used only to set up the VmPoolType.
Fixed by removing this logic, as the VmPoolType does not make sense
for the VM (and is not used anywhere), so does not need to be set up.
Change-Id: I030f89447df4a75dca3e52a3986e2a07a086a677
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalItemModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/VmItemBehavior.java
2 files changed, 0 insertions(+), 23 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6818
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I030f89447df4a75dca3e52a3986e2a07a086a677
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>