Change in ovirt-hosted-engine-ha[master]: storage: validating NFS/gluster paths
Sandro Bonazzola has submitted this change and it was merged.
Change subject: storage: validating NFS/gluster paths
......................................................................
storage: validating NFS/gluster paths
Validating NFS/gluster paths with os.path.normpath
as VDSM does.
Try to cleanly disconnect a previously connected
storage server if the storage server is already mounted
on a wrong path. Explicitly cleanup
/var/run/vdsm/storage/{sd} since VDSM is not and on
the other side it also doesn't refresh the link
if they are already there resulting in broken links.
Asking the user to reboot if disconnectStorageServer fails
(it will clean the whole /var/run becouse is on tmpfs).
Change-Id: I98273e99f1b855a4d96be706d864842e2ed61e1f
Bug-Url: https://bugzilla.redhat.com/1300749
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M ovirt_hosted_engine_ha/agent/hosted_engine.py
M ovirt_hosted_engine_ha/env/constants.py.in
M ovirt_hosted_engine_ha/lib/exceptions.py
M ovirt_hosted_engine_ha/lib/storage_server.py
4 files changed, 154 insertions(+), 9 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/52836
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I98273e99f1b855a4d96be706d864842e2ed61e1f
Gerrit-PatchSet: 21
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>