Arik Hadas has submitted this change and it was merged. Change subject: core: Console related VmDynamic properties changed together ...................................................................... core: Console related VmDynamic properties changed together VmDynamic business entity has 3 properties identifying: consoleCurrentUserName, consoleUserId and clientIp. Client IP address is updated when the user connects to and disconnects from console, "consoleUserId" is updated in SetVmTicketCommand and when VM is started. I.e. it survives console disconnection. Before this patch "consoleCurrentUserName" was set similarly as "consoleUserId" but also set to `null` during user disconnection form console. Thus after console disconnect "consoleCurrentUserName" did not correspond to "consoleUserId" This patch unifies behavior of "consoleCurrentUserName" and "consoleUserId" so that they both survives console disconnect. Frontend is altered to to behave the same way as before i.e. "Console User" is only showed if the user is actually connected. Change-Id: Iff69ffd09a252f24bd66981ffbde80830ef74e5b Signed-off-by: Jakub Niedermertl <jniederm@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalItemModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuestInfoModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/pool/SubTabPoolVmView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/template/SubTabTemplateVmView.java 6 files changed, 19 insertions(+), 15 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/56002 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff69ffd09a252f24bd66981ffbde80830ef74e5b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>