Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Small ScrollableTabBar improvements ...................................................................... webadmin,userportal: Small ScrollableTabBar improvements 1. ScrollableTabBarView: - removed "implements HasLoadHandlers" - removed fireEvent + addLoadHandler methods - the "+1 width adjustment" comment moved to appropriate location 2. ModelBoundTab: - added setAccessible override that fires TabAccessibleChangeEvent whenever tab's accessibility changes Change-Id: Ib7ffdb2827067b35320fd43d37db80479df6605d Signed-off-by: Vojtech Szocs <vszocs@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/ScrollableTabBarView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tab/ModelBoundTab.java 2 files changed, 15 insertions(+), 19 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Looks good to me, but someone else must approve Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23104 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7ffdb2827067b35320fd43d37db80479df6605d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs@redhat.com> Gerrit-Reviewer: Alexander Wels <awels@redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server