From Tal Nisan <tnisan@redhat.com>:
Tal Nisan has submitted this change and it was merged. Change subject: core: Properly adjust # of usb-controllers in UpdateTemplate & AddVm ...................................................................... core: Properly adjust # of usb-controllers in UpdateTemplate & AddVm The VmDeviceUtils#updateUsbSlots method was not being called in the flows in UpdateVmTemplateCommand and AddVmCommand, which resulted in creation of templates (and consequently also VMs) with incorrect number of usb controllers and thus preventing the VM to be run in some cases. Change-Id: Ic8fbae5d863307bc423c3e04cfd56c370a850863 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1430009 Signed-off-by: Martin Betak <mbetak@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 3 files changed, 21 insertions(+), 20 deletions(-) Approvals: Jenkins CI: Passed CI tests Martin Betak: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/73803 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8fbae5d863307bc423c3e04cfd56c370a850863 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Martin Betak <mbetak@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>