Tal Nisan has submitted this change and it was merged. Change subject: aaa: Remove "active" from groups ...................................................................... aaa: Remove "active" from groups New optimized and reduced user sync algorithm, is syncing users and the groups users actually belongs to. This means that if there is group persisted at the database which does not exist at the authz provider, it will be never reached and hence not synchronized. As result, the active/inactive flag in this case is useless as it will be never changed, nor has any effect. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120720 Change-Id: Id12a172273228609715c7d09c4d173a83478c82c Topic: AAA Signed-off-by: Yair Zaslavsky <yzaslavs@redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/aaa/DbGroup.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/aaa/LdapGroup.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbGroupDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DbGroupDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/user/SubTabUserGeneralView.java M packaging/dbscripts/ad_groups_sp.sql M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_05_0890_remove_active_column_from_groups.sql 10 files changed, 23 insertions(+), 66 deletions(-) Approvals: Alon Bar-Lev: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31551 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id12a172273228609715c7d09c4d173a83478c82c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski@gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server