Tal Nisan has submitted this change and it was merged. Change subject: core: Move disk loading in AttachDiskToVmCommand to init part ...................................................................... core: Move disk loading in AttachDiskToVmCommand to init part Using database operations in a class constructor is a bad practice, moved the disk loading part in AttachDiskToVmCommand which is needed for the lock map to the init part which runs before the initialize of the lock map Change-Id: I979e57d64b9f21fcbdd8e543defc03e9461f1a1a Signed-off-by: Tal Nisan <tnisan@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AttachDiskToVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/AttachDiskToVmCommandTest.java 2 files changed, 7 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Verified; Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55419 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I979e57d64b9f21fcbdd8e543defc03e9461f1a1a Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>