Change in ovirt-engine[master]: core: HotPlugDiskToVmCommandTest @Spy annotation
Tal Nisan has submitted this change and it was merged.
Change subject: core: HotPlugDiskToVmCommandTest @Spy annotation
......................................................................
core: HotPlugDiskToVmCommandTest @Spy annotation
Spy the command with the @Spy annotation instead of explicitly calling
Mockito.spy in order to set the ground for using injected mocks in
these tests in the future.
Note that VmCommand initializes its osRepository directly as a data
members with a SimpleDependencyInjector, so it must be mocked before the
command is created - i.e., in a @BeforeClass method in a static context.
Change-Id: Iddf8b1ae36e0466dc4b6e121fbac05789834788f
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/HotPlugDiskToVmCommandTest.java
1 file changed, 13 insertions(+), 6 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/64716
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iddf8b1ae36e0466dc4b6e121fbac05789834788f
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>