Change in ovirt-engine[ovirt-engine-3.3]: core: set address explicitly for VirtIO-SCSI devices
Itamar Heim has submitted this change and it was merged.
Change subject: core: set address explicitly for VirtIO-SCSI devices
......................................................................
core: set address explicitly for VirtIO-SCSI devices
Upon VM start, libvirt uses automatic address allocation for defining
addresses for each device (when not defined addresses explicitly).
As part of the automatic allocation, libvirt limits maximum units
(disks) for each controller [6 (narrow bus) / 15 (wide bus)].
In order to bypass this limitation, engine should set each device
address explicitly while keeping unit value (disk's index in
VirtIO-SCSI controller) unique and consecutive in the VM devices.
More details and full discussion:
https://www.redhat.com/archives/libvir-list/2013-November/msg01113.html
Change-Id: Iee79ff3f72b8018d0c26b37503f480643a845765
Bug-Url: https://bugzilla.redhat.com/1035453
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugDiskVDSCommand.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java
5 files changed, 95 insertions(+), 6 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22385
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iee79ff3f72b8018d0c26b37503f480643a845765
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server