Allon Mureinik has submitted this change and it was merged.
Change subject: core: SetupNetworksVDSCommand supportedClusterVersionsAvailable
......................................................................
core: SetupNetworksVDSCommand supportedClusterVersionsAvailable
According to the variable's name and the check it performs it's clear
that the code currently has a logical error, and the check should be
negated - supported cluster versions are available if the method does
NOT return an empty set.
Change-Id: Ife002879723e18af450f0c79627d1f7ef606d5b5
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
Yevgeny Zaspitsky: Looks good to me, but someone else must approve
--
To view, visit
https://gerrit.ovirt.org/54774
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ife002879723e18af450f0c79627d1f7ef606d5b5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>