From Vojtech Szocs <vszocs(a)redhat.com>:
Vojtech Szocs has submitted this change and it was merged.
Change subject: frontend: Small fixes
......................................................................
frontend: Small fixes
- OvirtXsrfProtectedServiceServlet:
- remove unnecessary null check
- ApplicationLogManager:
- remove unnecessary "final" (method param)
In GWT applications, using "final" keyword makes sense when
following a specific design (e.g. immutability) or when we
need to satisfy Java lang. constraints (e.g. must refer to
"final" outer variable from inside an inner class).
Other than that, no need to use "final" as the GWT compiler
takes care of any (static analysis based) optimizations when
doing Java-to-JS compilation.
Change-Id: Ie9f45278bb007d93a549347817851a1859b86ddc
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/OvirtXsrfProtectedServiceServlet.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/logging/ApplicationLogManager.java
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Greg Sheremeta: Looks good to me, approved
Vojtech Szocs: Verified
--
To view, visit
https://gerrit.ovirt.org/77041
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie9f45278bb007d93a549347817851a1859b86ddc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>