Change in ovirt-engine[master]: webadmin: Fix assigning permission to group
Martin Peřina has submitted this change and it was merged.
Change subject: webadmin: Fix assigning permission to group
......................................................................
webadmin: Fix assigning permission to group
Patch I5b1750301a48c874f979f91ce7680b610ba03516 introduces split views
of users or groups when assigning permissions. Unfortunately current
GWT representation of users and groups is very broken as we use DbUser
class to represent both users and groups. That led to unfortunate
decission to map group's Display Name to loginName attribute and this
mapping broke method isGroup() which uses loginName to distinguish
between user or group (another very broken design), which led to an
error during assigning permissions to a group. This flow didn't insert
group into ad_groups table, which means that this permission is not
loaded on user login.
This patch fixes assignment of a permission to a group by using DbUser
attribute note (which is not used otherwise) instead of loginName (it's
a hack, but at least it doesn't break existing functionality).
Change-Id: I12bc5b0d158d2572883ef8baa65f0aca856ed0a8
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/AdElementListModel.java
2 files changed, 4 insertions(+), 2 deletions(-)
Approvals:
Martin Peřina: Verified
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/54764
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I12bc5b0d158d2572883ef8baa65f0aca856ed0a8
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>