Change in ovirt-engine-sdk[master]: codegen, sdk: Fix name of "parentclass" parameter
Juan Hernandez has submitted this change and it was merged.
Change subject: codegen, sdk: Fix name of "parentclass" parameter
......................................................................
codegen, sdk: Fix name of "parentclass" parameter
A previous change in the code generator induced a change in the names of
some of the the "parentclass" parameters of entity brokers. For example,
the constructor of the "ClusterAffinityGroupVM" broker class changed
from this:
def __init__(self, clusteraffinitygroup, vm, context):
To this:
def __init__(self, affinitygroup, vm, context):
This change shouldn't affect any client of the SDK, because this is an
implementation detail of the broker classes, and clients shouldn't rely
on this, but the CLI does rely, as it uses the parameter name to figure
out the type name of the parent broker:
clusteraffinitygroup -> ClusterAffinityGroup
The result is that the CLI doesn't find the correct parent class, and
that means that autocompletion doesn't work correctly.
This patch reverts to the previous behaviour so that the CLI will work
as expected.
Change-Id: I36f6033eed5fb0a83964743e61e4072c21f07dee
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M generator/src/main/java/org/ovirt/engine/sdk/generator/python/SubResource.java
M src/ovirtsdk/infrastructure/brokers.py
2 files changed, 178 insertions(+), 179 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39616
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I36f6033eed5fb0a83964743e61e4072c21f07dee
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org