Liron Aravot has submitted this change and it was merged. Change subject: core: db deadlock by disk image dynamic updates ...................................................................... core: db deadlock by disk image dynamic updates VmsMonitoring updates the disk image dynamic table with the dynamic image data retrieved from the vm. Different engine flows can be executed when the vm is up, when the different flows end its attempted to complete the image data to the engine. VmsMonitoring performs batch update on sorted collection, while currently the updates done by the different flows that inheirt from BaseImagesCommand aren't sorted - as both updates may be executed in transaction we might reach a deadlock. This patch solves the deadlock by performing the image dynamic update out of transaction when its performed from the code in BaseImagesCommand which should solve the issue. This updates just sets the size retrieved from the storage, so we shouldn't care if its commited even of the rest of the changes are rolled back. Change-Id: Ie1645bd1f6bc991f9ec8501ad8aa8dd7d8987ee5 Bug-Url: https://bugzilla.redhat.com/1342317 Signed-off-by: Liron Aravot <laravot@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/BaseImagesCommand.java 1 file changed, 14 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/58705 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1645bd1f6bc991f9ec8501ad8aa8dd7d8987ee5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>