From Vojtech Szocs <vszocs@redhat.com>:
Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Improve GWT symbol map handling ...................................................................... webadmin,userportal: Improve GWT symbol map handling Before this patch, GWT .symbolMap files were installed through optional `{webadmin-portal,userportal}-debuginfo` RPM packages, which used the following layout: $PREFIX/share/ovirt-engine/gwt-symbols/webadmin/symbolMaps/ $PREFIX/share/ovirt-engine/gwt-symbols/userportal/symbolMaps/ with above directories containing <gwtPermStrongName>.symbolMap files. This had two main drawbacks: 1, GWT symbol maps were optional (not available right after Engine installation), imposing one extra step when trying to diagnose and fix GWT UI related problems 2, GWT symbol maps are big: 9 locales x 3 user agents = 27 .symbolMap files for each GWT application, for WebAdmin each .symbolMap file is ~37 M (x 27 = ~1 G) After this patch, GWT .symbolMap files are part of the core UI packages, using the following layout: $PREFIX/share/ovirt-engine/gwt-symbols/webadmin/symbolMaps.zip $PREFIX/share/ovirt-engine/gwt-symbols/userportal/symbolMaps.zip This solves both issues listed above. In case of an uncaught UI exception, `OvirtRemoteLoggingService` servlet opens the .zip file (using Java 8 zip FileSystem support) and streams relevant .symbolMap content needed for Java stack trace de-obfuscation. This also means that `{webadmin-portal,userportal}-debuginfo` RPM packages are now unnecessary and are therefore removed. Change-Id: I083a3b8ad5588f56b8569c862240591a44002326 Bug-Url: https://bugzilla.redhat.com/1431545 Signed-off-by: Vojtech Szocs <vszocs@redhat.com> --- M Makefile M backend/manager/modules/restapi/apidoc/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml A frontend/webadmin/modules/frontend-assemblies/pom.xml A frontend/webadmin/modules/frontend-assemblies/src/main/resources/assemblies/gwt-symbols.xml D frontend/webadmin/modules/frontend-symbols/pom.xml D frontend/webadmin/modules/frontend-symbols/resources/userportal/.keep D frontend/webadmin/modules/frontend-symbols/resources/webadmin/.keep M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/OvirtRemoteLoggingService.java M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M ovirt-engine.spec.in M pom.xml 15 files changed, 162 insertions(+), 144 deletions(-) Approvals: Jenkins CI: Passed CI tests Greg Sheremeta: Verified; Looks good to me, approved Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/75420 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I083a3b8ad5588f56b8569c862240591a44002326 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs@redhat.com> Gerrit-Reviewer: Alexander Wels <awels@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Barak Korren <bkorren@redhat.com> Gerrit-Reviewer: Eyal Edri <eedri@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme@redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Martin Betak <mbetak@redhat.com> Gerrit-Reviewer: Martin Peřina <mperina@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo@redhat.com> Gerrit-Reviewer: Scott Dickerson <sdickers@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>