Allon Mureinik has submitted this change and it was merged.
Change subject: core: MapEntry iterator in PostgresDbEngineDialect
......................................................................
core: MapEntry iterator in PostgresDbEngineDialect
Iterated over the entries in
extractOutputParameters(CallableStatement,List) instead of the keySet
for better performance.
Note that this addressed the FindBugs issue of WMI_WRONG_MAP_ITERATOR
for this class.
Change-Id: I42c320fd77c485b787e94899c4944c39d6fddec8
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/PostgresDbEngineDialect.java
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/11909
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I42c320fd77c485b787e94899c4944c39d6fddec8
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>