Change in ovirt-engine[master]: webadmin: Aggregate error messages in Frontend.runMultipleAc...
Lior Vernia has submitted this change and it was merged.
Change subject: webadmin: Aggregate error messages in Frontend.runMultipleActions()
......................................................................
webadmin: Aggregate error messages in Frontend.runMultipleActions()
Added the ability to aggregate error messages when invoking
Frontend.runMultipleActions(). This is useful for cases where batch
operations need to be run serially, and even though one failure
shouldn't prevent the subsequent operations from executing, errors
still need to be aggregated to be shown in one error dialog.
To process the multiple error messages of the failed operations, the
IFrontendEventsHandler.runMultipleActionFailed() method was extended
slightly to be able to handle failures that aren't canDoAction()
failures.
Change-Id: I0236b7d9316dff3d9bd22f2127318eefc37bbda1
Bug-Url: https://bugzilla.redhat.com/1048752
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java
M
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/IFrontendEventsHandler.java
M
frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/FrontendActionTest.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/FrontendEventsHandlerImpl.java
4 files changed, 79 insertions(+), 30 deletions(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25837
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0236b7d9316dff3d9bd22f2127318eefc37bbda1
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server