Tal Nisan has submitted this change and it was merged. Change subject: webadmin: disks sub-tab - fix columns creation ...................................................................... webadmin: disks sub-tab - fix columns creation Following sorting support, disks columns instantiation should be ensured to happen once. Otherwise, the columns get duplicated on type navigation (radio-buttons of all/images/directlun). Hence, applied the same solution introduced in [1] on MainTabDiskView to disks sub-tab as well. [1] http://gerrit.ovirt.org/29375/ Change-Id: Idc774e26c9a3d954e9d7b8a4fee9206358269926 Signed-off-by: Daniel Erez <derez@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/BaseVmDiskListModelTable.java 1 file changed, 45 insertions(+), 14 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/30004 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc774e26c9a3d954e9d7b8a4fee9206358269926 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server