From Allon Mureinik <amureini@redhat.com>:
Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80265 ) Change subject: core: Remove StorageServerConnection from StorageServerConnectionLunMapDaoTest ...................................................................... core: Remove StorageServerConnection from StorageServerConnectionLunMapDaoTest The only part of the StorageServerConnection used in StorageServerConnectionLunMapDaoTest is its ID, which can just be taken from the FixturesTool constant. This patch removes the roundtrip to the database that retrieves the unneeded object in order to clean up the test and make it easier to maintain. As a side bonus, removing this DAO call from the setup also speeds up the test. Change-Id: Ib7a62010021111069604c9b9cf5f01fc2ce891c3 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageServerConnectionLunMapDaoTest.java 1 file changed, 2 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/80265 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7a62010021111069604c9b9cf5f01fc2ce891c3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Eli Mesika <emesika@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>