Change in ovirt-engine[master]: core: skip vm monitoring if fetch failed
Omer Frenkel has submitted this change and it was merged.
Change subject: core: skip vm monitoring if fetch failed
......................................................................
core: skip vm monitoring if fetch failed
in case fetching vms info from vdsm failed
(for example network error on list/getAllStats)
there is no point in processing the result, and currently fails with
NPE.
Change-Id: Ic47867efe9aed64bffcf8fc428c47b6cbfdf5746
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1196040
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/PollVMStatsRefresher.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsListFetcher.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsStatisticsFetcher.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/EventVMStatsRefresher.java
M
backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VmsListFetcherTest.java
5 files changed, 52 insertions(+), 20 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Omer Frenkel: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/42766
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic47867efe9aed64bffcf8fc428c47b6cbfdf5746
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org