3:51 a.m.
Itamar Heim has submitted this change and it was merged.
Change subject: core: allow current master domain to be selected as the new master
......................................................................
core: allow current master domain to be selected as the new master
Currently the current master domain cannot be selected as the new
master, which can cause to the system to not be able to recover in case
that it's the only available domain.
This patch allows to perform reconstruct using the master domain in case
that we know that it's accessible -
1. Getting WrongMasterDomain error from vdsm means that we could get to
the master domain metadata.
NOTE: in that case, the reconstruct command will be executed with
parameter indicating that the current master can be selected as the new
master - but the host that return the WrongMasterDomain error or the master
domain id as the master domain id as the id of the domain to reconstruct to aren't
being passed to the command - this is being done to avoid possible
issues (for example: failing to reconstruct to that domain although we
can read the metadata, keep trying through the same host..etc).
The intention here is to improve the current situation for most of the
usecases.
2. When the master domain info in the db is different then the
info received from getStoragePoolInfo.
Change-Id: I705298d4f94b4afacc3ca028bb0a4e6080ac5a46
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1016118
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ReconstructMasterParameters.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
7 files changed, 73 insertions(+), 40 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22431
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I705298d4f94b4afacc3ca028bb0a4e6080ac5a46
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server