Juan Hernandez has submitted this change and it was merged. Change subject: core: Force version 3.x of findbugs ...................................................................... core: Force version 3.x of findbugs This patch changes the findbugs configuration so that instead of using a custom plugin it uses an artifact containing the shared filters. This artifact is then added to the class path of the findbugs plugin, together with version 3.x of findbugs. This allows us to use the old version of the plugin (which supports multiple filter files) with the new version of findbugs itself (which supports Java 8). In the future, we should be able to use the new version of the plugin, when it eventually supports multiple filter files: Support multiple include and exclude filter files https://github.com/gleclaire/findbugs-maven-plugin/pull/28 Change-Id: Idf0d7202c125320188280ffc9eae1ba36c785fc2 Signed-off-by: Juan Hernandez <juan.hernandez@redhat.com> --- M backend/manager/extensions-tool/pom.xml M backend/manager/modules/aaa/pom.xml A backend/manager/modules/auth-plugin/exclude-filters.xml M backend/manager/modules/bll/pom.xml M backend/manager/modules/branding/pom.xml M backend/manager/modules/builtin-extensions/pom.xml M backend/manager/modules/common/pom.xml M backend/manager/modules/compat/pom.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/docs/pom.xml M backend/manager/modules/extensions-api-root/extensions-api/pom.xml M backend/manager/modules/extensions-api-root/pom.xml M backend/manager/modules/extensions-manager/pom.xml A backend/manager/modules/logger/exclude-filters.xml M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/interface/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/types/pom.xml M backend/manager/modules/scheduler/pom.xml M backend/manager/modules/searchbackend/pom.xml M backend/manager/modules/services/pom.xml M backend/manager/modules/utils/pom.xml M backend/manager/modules/uutils/pom.xml M backend/manager/modules/vdsbroker/pom.xml M backend/manager/modules/welcome/pom.xml M backend/manager/tools/pom.xml M build-tools-root/jboss-modules-maven-plugin/pom.xml A build-tools-root/ovirt-checkstyle-extension/exclude-filters.xml A build-tools-root/ovirt-findbugs-filters/pom.xml R build-tools-root/ovirt-findbugs-filters/src/main/resources/exclude-filters-general.xml D build-tools-root/ovirt-findbugs-maven-plugin/pom.xml D build-tools-root/ovirt-findbugs-maven-plugin/src/main/java/org/ovirt/maven/plugins/findbugs/FindbugsMojo.java M build-tools-root/pom.xml D findbugs.sh M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/uicommonweb/pom.xml M frontend/webadmin/modules/uicompat/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M pom.xml 43 files changed, 139 insertions(+), 1,879 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve; Passed CI tests Juan Hernandez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46403 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf0d7202c125320188280ffc9eae1ba36c785fc2 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: David Caro <dcaroest@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo@redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi@redhat.com> Gerrit-Reviewer: automation@ovirt.org