Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Fix table context menu ...................................................................... webadmin,userportal: Fix table context menu Before this patch, CellTable's CellPreviewHandler was used to capture 'mousedown/right-click' events to select the row where mouse was pointing. After that, CellTable's ContextMenuHandler was used to capture 'contextmenu' events to prevent the default browser-specific context menu, and to show application-specific table context menu. In some cases, CellPreviewHandler prevented ContextMenuHandler to be invoked properly, which caused the default browser-specific context menu to appear (instead of application-specific one). This patch fixes the above mentioned problem by moving CellPreviewHandler logic into ContextMenuHandler, and using deferred command when showing application-specific context menu. This patch also fixes a problem when clicking "outside" the table (within its parent DIV element that fills up remaining space vertically) doesn't cause the application-specific context menu to appear. Change-Id: Ic699cb5880be54cb0402cd3f1d176b635d188bf0 Signed-off-by: Vojtech Szocs <vszocs@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/AbstractActionPanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java 2 files changed, 74 insertions(+), 34 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7820 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic699cb5880be54cb0402cd3f1d176b635d188bf0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen@redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs@redhat.com>