Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: edit pool dialog was not always filled properly ...................................................................... webadmin: edit pool dialog was not always filled properly The HW part should be filled by InstanceTypeManager and the SW part by behavior classes. In the current implementation the instance type manager was bypassed in some cases and only used as a signal when to pass the control back to it. Fixed by moving the HW related logic to Instance TypeManager where it belongs to and let the SW part in the behavior. Change-Id: I0866a3d23ba946c5a9f497b03a9b4537aea750ee Bug-Url: https://bugzilla.redhat.com/1282853 Signed-off-by: Tomas Jelinek <tjelinek@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingPoolModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/ExistingPoolInstanceTypeManager.java 2 files changed, 33 insertions(+), 26 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/48850 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0866a3d23ba946c5a9f497b03a9b4537aea750ee Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>