Roy Golan has submitted this change and it was merged.
Change subject: core: fix intermittent DAO test failure
......................................................................
core: fix intermittent DAO test failure
Problem:
DAO test testGetAllVmNumaNodeByVmId was failing sometimes.
Fix:
Test is not assuming any positional placement for expected values.
Test is searching for expected values in returned objects.
Change-Id: I5c820d25195d92e9df61ec622339c3de696f7ed2
Bug-Url:
https://bugzilla.redhat.com/1177259
Signed-off-by: Dudi Maroshi <dudi(a)redhat.com>
---
M
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmNumaNodeDaoTest.java
1 file changed, 26 insertions(+), 6 deletions(-)
Approvals:
Dudi Maroshi: Verified
Roman Mohr: Looks good to me, but someone else must approve
Allon Mureinik: Looks good to me, but someone else must approve
Roy Golan: Looks good to me, approved; Passed CI tests
--
To view, visit
https://gerrit.ovirt.org/45614
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5c820d25195d92e9df61ec622339c3de696f7ed2
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>