Change in ovirt-engine[ovirt-engine-3.5]: core: Allow VM disks editing after enabling quota on data ce...
Tal Nisan has submitted this change and it was merged.
Change subject: core: Allow VM disks editing after enabling quota on data center
......................................................................
core: Allow VM disks editing after enabling quota on data center
Diagnostics:
------------
After enabling quota on data center.
The recent quota id for a disk (in the database) is null.
And the current quota id from GUI has value
(current quota id = the selected quota in the list box).
CanDoAction in UpdateVmDiskCommand prevent change to quota id while vm
is running (rightfully).
Therefore detects quota id change:
for existing disks after quota is enabled in data center.
Short term solution:
-------------------
If recent quota id on disk is null always assume there is no change to
quota id.
Long term solution:
-------------------
Define a policy for disks with un-initilized quota.
Change-Id: Iff9c01b853f8d2a8897866cfe36f734eef179310
Bug-Url: https://bugzilla.redhat.com/1193643
Signed-off-by: Dudi Maroshi <dudi(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
1 file changed, 12 insertions(+), 0 deletions(-)
Approvals:
Dudi Maroshi: Verified
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/43951
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iff9c01b853f8d2a8897866cfe36f734eef179310
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org