Change in ovirt-engine[master]: core: @Spy gluster georep session commands
Allon Mureinik has submitted this change and it was merged.
Change subject: core: @Spy gluster georep session commands
......................................................................
core: @Spy gluster georep session commands
Cleaned up the gluster geo rep commands tests to use the @Spy
annotation in preparation for injecting the DAOs.
This patch includes:
- Moving the definition of the command to the base class
GepRepSessionCommandTest and @Spying it there.
- Thus, there is only only command object per test, so all the
methods receiving commands as parameters were redone to use the
member.
- Wherever possible, these now argument-less methods were annotated
with @Before to avoid having to call them explicitly in each test.
Change-Id: Icaea6b86e36784d53fbe98ab3ef202c202f03b79
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeGeoRepSessionCommandTest.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/DeleteGeoRepSessionCommandTest.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GeoRepSessionCommandTest.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/PauseGlusterVolumeGeoRepSessionCommandTest.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/ResumeGeoRepSessionCommandTest.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StopGeoRepSessionCommandTest.java
6 files changed, 75 insertions(+), 105 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/64612
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icaea6b86e36784d53fbe98ab3ef202c202f03b79
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>