Change in ovirt-engine[master]: 16. core : Handle incomplete tasks on server restart
Yair Zaslavsky has submitted this change and it was merged.
Change subject: 16. core : Handle incomplete tasks on server restart
......................................................................
16. core : Handle incomplete tasks on server restart
This patch changes the way asyc task placeholders are
cleared on server restart for commands that are partially
submitted to vdsm.
If a task has 4 placeholders and only 2 have been submitted
to vdsm, the database has 2 tasks with vdsm id and 2 with
empty vdsm id on server restarted.
When the server is restarted the tasks are grouped by root
command id and the commands that have partially submitted
tasks are handled differently. The task placeholder with
empty vdsm id are removed from the database. The tasks
which have vdsm id are added to the partiallyCompletedCommandTasks
list. On storage up event when AddStoragePoolExistingTasks is called
The task is marked for failure and once polling is done, they are
failed and removed from database.
http://www.ovirt.org/Features/AsyncTaskManagerChanges_3.3
Change-Id: I3a979d816d9ec8cf25119a33742c8e6af4ff42a8
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskFactory.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SPMAsyncTask.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmTemplateParameters.java
5 files changed, 218 insertions(+), 82 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15630
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3a979d816d9ec8cf25119a33742c8e6af4ff42a8
Gerrit-PatchSet: 32
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server