Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Handle storage domain types version checks correctly
......................................................................
webadmin: Handle storage domain types version checks correctly
The method responsible to check whether a storage type is supported in a
DC version used to return boolean, in cases that there is no info on
whether the type is supported (for instance when the DC is null when
selecting 'none' as the DC) the unboxing of the null Boolean resulted in an
NPE.
This was fixed by returning Boolean from the method and comparing the
result correctly.
Change-Id: I763aa67192f9d7bbf1e28bce273ad90c232ae125
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
Bug-Url:
https://bugzilla.redhat.com/1294089
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/FileStorageModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/GlusterStorageModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/IStorageModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NewEditStorageModelBehavior.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/PosixStorageModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModelBase.java
6 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
--
To view, visit
https://gerrit.ovirt.org/51090
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I763aa67192f9d7bbf1e28bce273ad90c232ae125
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>