10:55 p.m.
Einav Cohen has submitted this change and it was merged.
Change subject: userportal: Optimize basic view
......................................................................
userportal: Optimize basic view
1. Fixed VmPool.equals method
2. Added UserPortalItemModel.entityStateEqualTo method
containing VM/Pool entity state comparison logic
3. Fixed related NPE in UserPortalListModel that
occured when items == null, and added break statement
to optimize selected item handling loop
4. UserPortalBasicListModel provider now includes
original optimization logic:
* on first data update, just proceed to refresh UI
* on subsequent data update, proceed to refresh UI
only if there's (any) change in items
5. VM/Pool list presenter widget includes additional
optimization logic:
* reuse item presenter widgets (avoid recreating
item views) for existing items
* properly unbind/remove item presenter widgets
whose items are absent within new data
6. VM/Pool item presenter widget's setModel method
and related code refactored to allowed repeated
setModel invocations
Change-Id: I17b92858345de398dbc89d9141468ccea67963fe
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalBasicListModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalItemModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
M
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicListItemPresenterWidget.java
M
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicListPresenterWidget.java
M
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicListItemView.java
M
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/basic/UserPortalBasicListProvider.java
7 files changed, 218 insertions(+), 89 deletions(-)
Approvals:
Einav Cohen: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10509
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I17b92858345de398dbc89d9141468ccea67963fe
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>