Change in ovirt-engine[master]: core: AddStorageDomainCommonTest @Spy annotation
Tal Nisan has submitted this change and it was merged.
Change subject: core: AddStorageDomainCommonTest @Spy annotation
......................................................................
core: AddStorageDomainCommonTest @Spy annotation
Spy the command with the @Spy annotation instead of explicitly calling
Mockito.spy in order to set the ground for using injected mocks in
these tests in the future.
Note that StorageDomainManagementParameter#setStorageDomain had to be
made public to enable this change.
Change-Id: I6d1aa14f49ce6a69c48be35f4169901f46a0991d
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/AddStorageDomainCommonTest.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/StorageDomainManagementParameter.java
2 files changed, 12 insertions(+), 7 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved; Passed CI tests
Allon Mureinik: Verified
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/64736
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6d1aa14f49ce6a69c48be35f4169901f46a0991d
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>