Tal Nisan has submitted this change and it was merged. Change subject: core: redesign MemoryStorageHandlerTest to use mocks ...................................................................... core: redesign MemoryStorageHandlerTest to use mocks This patch redesigns the test class of MemoryStorageHandler to use mocks so that they will test the MemoryStorageHandler instead of the StorageDomainValidator. Change-Id: Ibe874762dda6967a1bc5e29c973fac7b00fbda70 Bug-Url: https://bugzilla.redhat.com/1186230 Signed-off-by: Idan Shaby <ishaby@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryStorageHandler.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/memory/MemoryStorageHandlerTest.java 2 files changed, 92 insertions(+), 44 deletions(-) Approvals: Tal Nisan: Looks good to me, but someone else must approve Jenkins CI: Verified; Looks good to me, but someone else must approve Allon Mureinik: Looks good to me, approved Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/40435 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe874762dda6967a1bc5e29c973fac7b00fbda70 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby@redhat.com> Gerrit-Reviewer: Ala Hino <ahino@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram@redhat.com> Gerrit-Reviewer: Candace Sheremeta <cshereme@redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland@redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk@redhat.com> Gerrit-Reviewer: automation@ovirt.org