Change in ovirt-engine[master]: core: GetAllDisksByVmIdQuery - proper list copying
Allon Mureinik has submitted this change and it was merged.
Change subject: core: GetAllDisksByVmIdQuery - proper list copying
......................................................................
core: GetAllDisksByVmIdQuery - proper list copying
Create the result list by passing the list from the DAO to the
constructor instead of iterating and calling add(disk).
This way we ensure the list is exactly the right size, and no wasted
memory or redundant regrows occur.
Change-Id: I3402084258aebf3cb9dcfa1d4c494281e95aeeb8
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllDisksByVmIdQuery.java
1 file changed, 1 insertion(+), 4 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15009
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3402084258aebf3cb9dcfa1d4c494281e95aeeb8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>