Change in ovirt-engine[master]: core: implement MetadataDiskDescriptionHandler as a singleton
Tal Nisan has submitted this change and it was merged.
Change subject: core: implement MetadataDiskDescriptionHandler as a singleton
......................................................................
core: implement MetadataDiskDescriptionHandler as a singleton
This patch is re-implementing MetadataDiskDescriptionHandler to be a
singleton so that it would be easier to test it.
Change-Id: I2832b4803d9a2b96a0e63973e0571c1b46892d3e
Related-To: https://bugzilla.redhat.com/1249130
Related-To: https://bugzilla.redhat.com/1219680
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUnregisteredDiskQuery.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MetadataDiskDescriptionHandler.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MetadataDiskDescriptionHandlerTest.java
5 files changed, 15 insertions(+), 7 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved; Passed CI tests
Maor Lipchuk: Looks good to me, but someone else must approve
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/45772
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2832b4803d9a2b96a0e63973e0571c1b46892d3e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org