Arik Hadas has submitted this change and it was merged. Change subject: core: Improve logging of VM prestart errors ...................................................................... core: Improve logging of VM prestart errors Checks performed inside VmPoolCommandBase.isVmFree() produce messages in the case of an error that give more details about the cause of the error. Currently these messages are simply discarded making debugging of VM prestart errors more difficult. This patch directs these messages into the engine log. The failure messages are logged only if VmPoolManager failed to prestart the required number of VMs. To avoid excessive logging, similar messages are grouped together and variable substitutions are ignored. Change-Id: Ib7a79c757d253bc484e9b18c18da6f918c9b41eb Signed-off-by: Shmuel Melamud <smelamud@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolMonitor.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ErrorMessageUtils.java 3 files changed, 65 insertions(+), 18 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51005 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7a79c757d253bc484e9b18c18da6f918c9b41eb Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi@redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>