Arik Hadas has submitted this change and it was merged.
Change subject: core: change the order of canDoAction checks on hibernate
......................................................................
core: change the order of canDoAction checks on hibernate
We check if the VM is part of pool after checking if the VM is
stateless. Since every VM in pool is stateless, we'll never get to this
check. This patch change the order of these checks, to get the specific
error for the case where the VM is part of pool.
In addition, removing redundant prefix on log printings.
Change-Id: Ie9b98e797ad3f38f19aea45be2f7fe8d1a7635a8
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java
1 file changed, 14 insertions(+), 8 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit
http://gerrit.ovirt.org/28899
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie9b98e797ad3f38f19aea45be2f7fe8d1a7635a8
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server