Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Fix small action button regression ...................................................................... webadmin: Fix small action button regression As part of the action button scrolling feature, action buttons that were supposed to be hidden were revealed. This patch tries to fix this, by only considering action buttons that were visible to begin with. I also found no reason to keep invoke setVisible(true) on buttons that were already rendered visible, nor to keep summing the widths of hidden buttons (which should be zero anyway, as I understand from the fact that buttons had been made visible to measure their widths). Change-Id: I3a977d2dc2bf929c9f0fb5853ba667cfe3728a37 Signed-off-by: Lior Vernia <lvernia@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/AbstractActionPanel.java 1 file changed, 9 insertions(+), 2 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23242 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a977d2dc2bf929c9f0fb5853ba667cfe3728a37 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia@redhat.com> Gerrit-Reviewer: Alexander Wels <awels@redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen@redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server