
Omer Frenkel has submitted this change and it was merged. Change subject: scheduling: Fix ConcurrentModificationException in runFilters() ...................................................................... scheduling: Fix ConcurrentModificationException in runFilters() Since the MultipleActionRunner invokes canDoActions in parallel, in case of multiple RunVmCommands it caused the SchedulingManager#canSchedule() method to call runFilters() concurrently which resulted in duplicate sort of the same ArrayList in sortFilters() method. Now RunFilters creates a local copy of the filters list and run sort on this private copy. Change-Id: I1725940c11c2cc07c20255c4474715020e36b56e Signed-off-by: Martin Betak <mbetak@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java 1 file changed, 9 insertions(+), 9 deletions(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Martin Betak: Verified Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44244 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1725940c11c2cc07c20255c4474715020e36b56e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak@redhat.com> Gerrit-Reviewer: Martin Sivák <msivak@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel@redhat.com> Gerrit-Reviewer: Roy Golan <rgolan@redhat.com> Gerrit-Reviewer: automation@ovirt.org