Change in ovirt-engine[master]: core: standardization of hibernate command
Arik Hadas has submitted this change and it was merged.
Change subject: core: standardization of hibernate command
......................................................................
core: standardization of hibernate command
1. Just start to create the disks in the execute phase, no need to
update the active snapshot's memory in advance - will do it in the
end-action phase, in case we managed to create the disks.
2. Change the way we get the created disks: instead of querying the DB
in the parent command, the add-disk command returns the created disk in
its end-action phase. This is a better approach since we will need to
have the same logic in import from external provider command.
3. Cleanup the end-with-failure case: in case of a failure, just need to
make sure we clean the memory from the active snapshot and remove the
disks (revert tasks).
Change-Id: Ib7c97fb3907b155eb5d5d03b665ab80814da8229
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromExternalProviderCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
3 files changed, 66 insertions(+), 72 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Maor Lipchuk: Looks good to me, but someone else must approve
Arik Hadas: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/37671
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib7c97fb3907b155eb5d5d03b665ab80814da8229
Gerrit-PatchSet: 31
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org